search

Meteor-Community-Packages / meteor-roles

Authorization package for Meteor, compatible with built-in accounts packages
http://meteor-community-packages.github.io/meteor-roles/
MIT License
921 stars 168 forks source link

Support for Meteor 3.0.1 #402

Open 67726e opened 2 months ago

67726e commented 2 months ago

When adding this package to a new, Meteor 3.0.1 application it attempts to install the old 1.2.0 version of alanning:roles.

Browsing the source code, it appears there are async functions available - does this library support Meteor 3.0.1?

github-actions[bot] commented 2 months ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

jankapunkt commented 2 months ago

Hi @67726e can you please open your .meteor/packages file and change alanning:roles to alanning:roles@4.0.0-rc.2!? I assume it's not considered, since still have released v4 only as RC. The v4 is supposed to be fully Meteor 3 compatible. If you have trouble with it, please let us know.

67726e commented 2 months ago

Hey @jankapunkt - that was just the fix I needed. I apologize for not checking the package.js on the feature branch :facepalm:

StorytellerCZ commented 1 month ago

V4 has been released, so this should no longer be an issue.

jankapunkt commented 1 month ago

@67726e can you confirm this works with v4 of this package?`

StorytellerCZ commented 1 month ago

Seems to be an issue with Meteor's version resolution system. Something in there decides that it needs to get to the ancient version of that package. Happened to me on other packages as well.