search

Meteor-Community-Packages / meteor-stylus

A fork of meteor:stylus with mquandalle:stylus plugins
MIT License
8 stars 5 forks source link

Fix tests #5

Closed GeoffreyBooth closed 5 years ago

GeoffreyBooth commented 5 years ago

The latest master tests fail for me:

$ meteor test-packages ./
[[[[[ Tests ]]]]]

=> Started proxy.
=> Started MongoDB.
compileStylusBatch: updating npm dependencies -- stylus, nib, jeet, rupture, axis, typographic, autoprefixer-stylus...
=> Errors prevented startup:

   While processing files with coagmano:stylus (for target web.browser):
   packages/local-test:coagmano:stylus/stylus_tests.styl: Stylus compiler error: stylus_tests.styl:3:81
   1| @import "stylus_tests.import.styl"
   2|
   3| import-from-json-dashy = load-var-from-json('test-settings.json', 'public.dashy')
   --------------------------------------------------------------------------------------^
   4|
   5| #stylus-tests
   6|   zoom: 1

   filePath.match is not a function

It looks like there’s an in-progress feature in the code, involving importing variables from JSON files. (I see a large commented-out function.) Seeing as there’s no reference to this in the README, I assume that this feature isn’t yet completed.

I’ve commented out its tests so that they pass, so that I can branch off of this to submit a new PR that has passing tests.

coagmano commented 5 years ago

Yeah I added that for use where I work, but never finished the tests.

The feature works, but suffers from caching issues, so it's not something that I was planning on documenting publicly.

I should clean it up at some point now it seems this has become the recommended stylus package for Meteor