search

Meteor-Community-Packages / meteor-timesync

NTP-style time synchronization between server and client, and facilities to use server time reactively in Meteor applications.
https://packosphere.com/mizzao/timesync
MIT License
118 stars 36 forks source link

Customize endpoint name #14

Closed wI2L closed 8 years ago

wI2L commented 9 years ago

Hi @mizzao

It would be usefull for me so i decided to create a pull request. Let me know if there is any problem with my code.

Regards,

William

mizzao commented 9 years ago

Hmm. I understand the motivation for this, but do you really think an application will use _timesync as an endpoint?

wI2L commented 9 years ago

I'm not sure to understand you. I think it should be possible to just change the name of the base url for this package, easily.

mizzao commented 9 years ago

I'm just asking why it would be necessary to do so. Is there something in your app that requires it?

wI2L commented 9 years ago

Not in my case. I'm just following the same idea from : https://github.com/CollectionFS/Meteor-CollectionFS#customizing-the-http-urls-and-headers I could be usefull to avoind conflicts or just to customize the path.

jaredthirsk commented 8 years ago

How about this, for a configuration-less approach?

https://github.com/jaredthirsk/meteor-timesync/commit/ce6eea1f83953a93f4d240aa6ad36cbb49b1725b

mizzao commented 8 years ago

I think #40 fixes this for you, but please open a new PR if you still have an issue.