Closed maxnowack closed 7 years ago
Hi @maxnowack, I've been rather busy lately, so I gave you commit access to merge this and make any changes you'd like. Thanks for following the code style and updating the tests.
If you give me your Meteor developer username, I can give you permission to publish new versions of the package as well. It would be really nice if you did that, as it would fix the strange issue raised in #42. :)
Hey @mizzao, sounds good. My meteor username is also maxnowack
Great, you can now publish new versions of the package. I usually use the following simple procedure for publishing, although you can do what works for you:
0.4.0
becomes 0.4.1
or 0.5.0
depending on how much changed)History.md
file to reflect all changes that will be in the new version. If you've been keeping it up to date (and it appears you have), this just involves inserting the above version number below vNEXT
.package.json
.git commit
(but don't push yet).meteor publish
git tag v0.x.y
and push the tag (git push origin 0.x.y
; this allows others to find the code for this version) and merge into master and push that too. (If you aren't rebasing the feature branch you may want to merge first before publishing)If publishing didn't work, you can fix things, amend the commit as necessary, then tag and push after verifying that it went through.
Thanks so much for your help!
If the client time has changed, but the server is unreachable,
serverTime
is undefined. Normally this case occurs if the computer wake up from hibernation and have no network connection. This change tries to guess the new offset. Guessing the offset only works if the server time hasn't changed (I think, in the most cases it’s UTC and it doesn’t change).