Meteor-Community-Packages / meteor-timesync

NTP-style time synchronization between server and client, and facilities to use server time reactively in Meteor applications.
https://packosphere.com/mizzao/timesync
MIT License
118 stars 36 forks source link

Fixed TimeSync returning NaN in meteor-desktop clients #50

Closed wreiske closed 5 years ago

wreiske commented 5 years ago

I'm working on a meteor-desktop app for work and ran into an issue where the TimeSync was returning NaN. This pull request fixes it, allowing TimeSync to work correctly in meteor-desktop clients.

mizzao commented 5 years ago

I don't have time to maintain this project anymore, so I gave you commit access to make any changes you'd like. It would be nice to follow the style used by the rest of the code and add some tests to this patch, if possible.

If you'd like to directly publish new versions of the package, just send me your Meteor username and I'll add you as a maintainer.

wreiske commented 5 years ago

If you'd like to directly publish new versions of the package, just send me your Meteor username and I'll add you as a maintainer.

Awesome, it'd be an honor. I use this package religiously across multiple projects.

My meteor username is: wreiske

Thanks!

mizzao commented 5 years ago

Awesome, you're in! If you want to help maintain anything else, like https://github.com/mizzao/meteor-user-status which uses this a lot, happy to add you there as well.

I usually use the following simple procedure for publishing, although you can do what works for you:

Thanks so much for your help!