search

Meteor-Community-Packages / meteor-typescript

Typescript compiler package
https://packosphere.com/refapp/meteor-typescript
MIT License
5 stars 2 forks source link

Disabling source maps does not work #11

Closed grossbart closed 1 year ago

grossbart commented 1 year ago

I can't find a way to disable source maps using this package. I have disabled them in my tsconfig.json, but then found that it didn't change anything.

When I change meteor-typescript-compiler and set the sourceMap option in optionsToExtend to false, it works: https://github.com/Meteor-Community-Packages/meteor-typescript-compiler/blob/master/meteor-typescript-compiler.ts#L362

Is there a reason that this is hard-coded or could it just be removed and be taken from tsconfig.json?

github-actions[bot] commented 1 year ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

perbergland commented 1 year ago

It seems like a natural option to be able to turn it off - I’ll try to remember to fix this next time I do a release, or if you want to create a PR for it?

perbergland commented 1 year ago

This has been implemented now, along with an override option via an environment variable

grossbart commented 1 year ago

Thanks a lot, I will give this a go next week 🙏