Meteor-Community-Packages / raix-push

DEPRECATED: Push notifications for cordova (ios, android) browser (Chrome, Safari, Firefox)
https://atmospherejs.com/raix/push
MIT License
513 stars 197 forks source link

Advanced - Remote image set as icon not working #222

Open sahanDissanayake opened 8 years ago

sahanDissanayake commented 8 years ago

Hi @raix ,

https://github.com/raix/push/blob/v3.x/docs/ADVANCED.md

Tested this on Samsung S6 and raix:push@3.0.2 and the icon just comes out normal as how it always has been.

Any thoughts please ?

Thanks

sampaiodiego commented 8 years ago

The current live version (3.0.2 - https://github.com/raix/push/commit/d17e1eb26ef03dab233a3f9170c876db952c968f from Oct 22) does not include the image support (introduced in Mar 3 https://github.com/raix/push/commit/fc5787408ac37fc22b8fd8d811b5ae40c6c91cad) unfortunately :disappointed:

The question is when the new version will be released?

I'm willing to do a PR to support extra data for GCM.

raix commented 8 years ago

can you give 3.0.3-rc.5 a go to see if it's still an issue? (I'll be happy to take pr's - mind the new version deprecates the json config files - hopefully this will allow less friction)