search

Meteor-Community-Packages / raix-push

DEPRECATED: Push notifications for cordova (ios, android) browser (Chrome, Safari, Firefox)
https://atmospherejs.com/raix/push
MIT License
515 stars 197 forks source link

Android 8 channel integration #359

Closed da314pc closed 5 years ago

shivang007 commented 5 years ago

@da314pc I tried in multiple android mobiles, the notification does not have a default icon of my app. Instead it's just a green colored square! Can you test if the same thing is happening with your build?

shivang007 commented 5 years ago

@da314pc I tried in multiple android mobiles, the notification does not have a default icon of my app. Instead it's just a green colored square! Can you test if the same thing is happening with your build?

Adding cordova-build-override with platform/android/res/drawable as @aboire suggested, solves this.

da314pc commented 5 years ago

@da314pc I tried in multiple android mobiles, the notification does not have a default icon of my app. Instead it's just a green colored square! Can you test if the same thing is happening with your build?

Adding cordova-build-override with platform/android/res/drawable as @aboire suggested, solves this.

Can you post what you added so I can add that to the readme

shivang007 commented 5 years ago

Can you post what you added so I can add that to the readme

Add your icon and logo in cordova-build-override/platforms/android/res/drawable Add your sound file in cordova-build-override/platforms/android/res/raw Like this:

da314pc commented 5 years ago

Can you post what you added so I can add that to the readme

Add your icon and logo in cordova-build-override/platforms/android/res/drawable Add your sound file in cordova-build-override/platforms/android/res/raw Like this:

I think we should use the default meteor way with the mobile config.js App.icons({ // Android 'android_mdpi': 'resources/icons/48x.png', 'android_hdpi': 'resources/icons/72x.png', 'android_xhdpi': 'resources/icons/96x.png', 'android_xxhdpi': 'resources/icons/144.png', 'android_xxxhdpi': 'resources/icons/192x.png' });

during the build

shivang007 commented 5 years ago

@da314pc I am already doing that in my mobile-config.js.

da314pc commented 5 years ago

@da314pc I am already doing that in my mobile-config.js.

If you were able to get the notifications working we can proceed with this pull request. Anyone who needs icons , we can refer them to the meteor guide. to add them during the build with the mobile config settings or just copy and paste them in the build override folder.

shivang007 commented 5 years ago

@da314pc I am already doing that in my mobile-config.js.

If you were able to get the notifications working we can proceed with this pull request. Anyone who needs icons , we can refer them to the meteor guide. to add them during the build with the mobile config settings or just copy and paste them in the build override folder.

Cool, push your latest code, resolve all the comments and we can proceed

da314pc commented 5 years ago

@da314pc I am already doing that in my mobile-config.js.

If you were able to get the notifications working we can proceed with this pull request. Anyone who needs icons , we can refer them to the meteor guide. to add them during the build with the mobile config settings or just copy and paste them in the build override folder.

Cool, push your latest code, resolve all the comments and we can proceed

I can't approve my own pull request. You guys have to review and approve. @shivang007 @aboire