Meteor-Community-Packages / react-router-ssr

Simple isomorphic React SSR for Meteor with subscribed data re-hydration
MIT License
24 stars 4 forks source link

Compatibility with meteor 3 #36

Open gustawdaniel opened 7 months ago

gustawdaniel commented 7 months ago

After command:

meteor update --release 3.0-beta.0

in the existing meteor 2 project I see error:

* meteor@1.1.14 <- livedata 1.0.18 <- communitypackages:fast-render 4.0.7-alpha.1 <-
communitypackages:react-router-ssr 3.0.4

in package.js of this package I see

Package.onUse(function _ (api) {
  api.versionsFrom('2.3');
  api.use(['ecmascript', 'communitypackages:fast-render@4.0.0', 'tmeasday:check-npm-versions@1.0.2']);

  api.mainModule('client.jsx', 'client');
  api.mainModule('server.jsx', 'server');
});

but proposed package should contain

Package.onUse((api) => {
  api.versionsFrom(['1.10', '2.3', '3.0-beta.0']);
  //                               ^^^^^^^ for testing your package with meteor 3.0

  api.versionsFrom(['1.10', '2.3', '3.0']);
  //                              ^^^^^^^ for meteor 3.0

according to

https://guide.meteor.com/3.0-migration#How-do-I-migrate-my-package-to-be-compatible-with-Meteor-3-0

github-actions[bot] commented 7 months ago

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously. Our goal is to provide long-term lifecycles for packages and keep up with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time. Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit a pull request, too! We will accompany you in the process with reviews and hints on how to get development set up.

Please also consider sponsoring the maintainers of the package. If you don't know who is currently maintaining this package, just leave a comment and we'll let you know

StorytellerCZ commented 7 months ago

Well, as you can guess from the code, this package is not yet Meteor 3 compatible. Though the fast render reference is strange, maybe it is trying to satisfy the Meteor 3 constraint by using the fast render alpha version.

copleykj commented 3 months ago

This will be worked on very soon.