Meteor-Mentor / meteorU

5 stars 3 forks source link

eslint and editorconfig from mantra #17

Closed sakulstra closed 8 years ago

sakulstra commented 8 years ago

This was probably to early. We should first decide if we want to go with mantra/react. I'd suggest we do, as it brings the advantage of having a defined folder structure and testing, but it's open for any input.

ecerroni commented 8 years ago

I don't know mantra, neither react. But I believe in learning by doing, so I vouche for using them.

Let's this project go with mantra/react

serkandurusoy commented 8 years ago

Did you guys watch the latest transmission episodes, especially the parts about mantra vs guide?

The takeaways are:

I strongly believe we should go with what guide has to offer. MDG is preparing a guide overhaul for 1.3 and it will be even better.

Regarding the react vs angular vs blaze discussion, I think we can touch and cover the complete ground here. I am currently working on a rough draft about what I have in mind about this project and it will surprize you in this regard ;)

Finally, ES2015 it definitely is!

sakulstra commented 8 years ago

I've seen the transmission episodes and got some other takeaways:

Pro:

Con:

Anyways, if we stick to one of them we can probably switch pretty easily, so i would suggest we go with whatever the mentors are more familiar with. I think till 1.3 is finally out (and perhaps even after that) mantra will get (a lot) at least some changes and it could get kind of tricky to always refactor our stuff - so going with the guide seems okay for me, too.

kaiyes commented 8 years ago

I am not really willing to use Mantra. I rather wait a bit for MDG's official Response. I believe that will be much better in every sense. MDG is a bit slow I agree, but when they come up with something, they nail it.

sakulstra commented 8 years ago

I'm no eslint guru but I think this setup should even work with blaze or am I wrong? So we could simply rebase and merge this? The discussion started by myself about mantra or not was kind of misleading - eslint is universal. For testing we can wait till 1.3 is out.

9

PS: But this eslint config will force us to use ES2015 and imports ...

serkandurusoy commented 8 years ago

I think we may actually move on to 1.3 and upgrade as new beta versions come in. And begin implementing eslint and imports

sakulstra commented 8 years ago

I'd love that. Ill do it in friday if noone else did it before :) Am 07.03.2016 12:35 nachm. schrieb "Serkan Durusoy" < notifications@github.com>:

I think we may actually move on to 1.3 and upgrade as new beta versions come in. And begin implementing eslint and imports

— Reply to this email directly or view it on GitHub https://github.com/Meteor-Mentor/meteor_mentor/pull/17#issuecomment-193215351 .

serkandurusoy commented 8 years ago

Great!