Meteor-Mentor / meteorU

5 stars 3 forks source link

codestyle #9

Closed sakulstra closed 8 years ago

sakulstra commented 8 years ago

Including some eslint(for example https://github.com/mantrajs/mantra-sample-blog-app/blob/master/.eslintrc) would be nice. So we have at least a common code style and can make an introduction into ci services.

serkandurusoy commented 8 years ago

+1

bearcanrun commented 8 years ago

+1. I haven't worked with many coding teams and from conversations, it sounds like quite a few of the members don't either on a regular basis. Any good resources for "Team Coding and Practices for Newbies"?

sakulstra commented 8 years ago

@bearcanrun , actually there isn't anything you have to learn, except for some eslint and even this is optional. When using sth. like eslint a modern editor will show you when your doing sth. wrong (wrong in terms of "no empty line at the end of a file", or "a line shouldn't be longer than 80 chars") - with eslint setup via ci all contributors are "forced" to use the same coding standards which increases readability - nothing else.

necmettin commented 8 years ago

considering we have and .eslintrc in the repo, close this?