MeteorDevelopment / meteor-client

Based Minecraft utility mod.
https://meteorclient.com
GNU General Public License v3.0
2.27k stars 844 forks source link

testInHotbar function not working correctly #3563

Open Julflips opened 1 year ago

Julflips commented 1 year ago

Describe the bug

The testInHotbar function of InvUtils doesn't find items in the most right slot. (You just have to replace the < with a <= in the for-loop, I am just too lazy to do a pull request)

Steps to reproduce

For example, when you activate crystalAura with autoSwitch and have crystals in the most right slot it won't crystal the enemy when it is not in the active slot.

Link to crash report/log if applicable (https://mclo.gs)

No response

Meteor Version

0.5.3

Minecraft Version

1.19.4

Operating System

Windows

Before submitting a bug report

Julflips commented 1 year ago

And if you print out every item in the loop of testInHotbar(Predicate predicate) it prints all 9 items?

RacoonDog commented 1 year ago

if this is true then findInHotbar is also bugged

Julflips commented 1 year ago

no findInHotbar() is fine since it uses the loop in find() which has the correct "<="

RacoonDog commented 1 year ago

it would appear as though i did in fact fuck up then