Better Tooltips causes crash when using the plugin Advanced Kits - Githubissues

MeteorDevelopment / meteor-client

Based Minecraft utility mod.

https://meteorclient.com

GNU General Public License v3.0

2.24k stars 829 forks source link

Better Tooltips causes crash when using the plugin Advanced Kits #4912

Closed jharrison123 closed 1 month ago

jharrison123 commented 1 month ago

Steps to reproduce

So after some tinkering i found out that its Better Tooltips causing the crash disabling the module prevents the crash

Link to crash report/log (upload to https://mclo.gs and paste resulting link here)

https://mclo.gs/RskY8ZD

Meteor Version

meteor client v0.5.8 build #2172

Minecraft Version

1.21.1

Operating System

Linux

Before submitting a crash report

[X] This crash wasn't already reported (I have searched crash reports on GitHub).
[X] This is a valid crash (I am able to reproduce this on the latest dev build).

RacoonDog commented 1 month ago

crash caused by ItemStack#getTooltip when an item has DataComponentTypes.HIDE_TOOLTIP since it short-circuits and returns List.of(), which is immutable