New Hooks to be approved

tredondo commented 9 years ago

Ping events for new hooks received on autopublish.meteor.com will be reported here.

At the same time, anyone being aware of the imminent creation of a new hook (e.g. after a PR for a new integration was merged) should write here to have admin users notified about it.

Admin users should revise all new hooks end eventually approve them from this page.

After the new hook is approved, please delete all related messages to keep this track clear!

tredondo commented 9 years ago

Received from hoppas/meteor-plugin-stylus to be revised!

@ViZhe, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 9 years ago

Received from hoppas/meteor-plugin-stylus to be revised!

@ViZhe, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 9 years ago

Received from hoppas/meteor-plugin-stylus to be revised!

@ViZhe, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 9 years ago

Received from codetheweb/zxcvbn to be revised!

@codetheweb, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from mizsha/meteor-user-settings to be revised!

@mizsha, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from formly-js/angular-formly-templates-material to be revised!

@kamilkisiela, thank you for testing autopublish: could you explain how you would like to use it?

kamilkisiela commented 8 years ago

@meteorpublish This is official package and I need to auto publish it.

trusktr commented 8 years ago

It'd be nice if we didn't have to go through this manual step.

zimme commented 8 years ago

@kamilkisiela Approved. @trusktr, Yeah that would be great, the problem is that the publish bot is added to all meteor packages projects which are approved for autopublish, which means that any user who have and approved package for autopublish have the ability to just change the name in package.js to another package which is setup for auto publish and they will be able to publish new versions of that package.

This is why we have a manual approve process.

What we've talked about before but no one have had time to actually look into at depth is generating a .meteorsession file for each package when doing this setup, when logging in with their meteor developer account.

If that works the publish server should be able to publish as the user setting up the auto publish. and the publishbot isn't needed to be a maintainer of the package.

kamilkisiela commented 8 years ago

@zimme I'm going to move all packages from formly-js to atmosphere. Can I message you or somebody else directly or each time has to write in this issue?

zimme commented 8 years ago

just start moving and as I see the package popup in this thread I'll approve them :+1:

kamilkisiela commented 8 years ago

@zimme ok, thanks

tredondo commented 8 years ago

Received from wieldo/meteor-autoformly to be revised!

@kamilkisiela, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from wieldo/angular-formly-validator to be revised!

@kamilkisiela, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from wieldo/angular-formly-transformer to be revised!

@kamilkisiela, thank you for testing autopublish: could you explain how you would like to use it?

zimme commented 8 years ago

@kamilkisiela, all the new hooks have been approved.

zimme commented 8 years ago

@mizsha, @codetheweb, approved your hooks too.

@ViZhe, I couldn't find your hook any longer, so I couldn't approve it.

splendido commented 8 years ago

@zimme @trusktr: @zimme is correct the thing about the name into package.js is now a potential problem only for the very first publish attempt. See 32582598ad22121a6ce374f62460d432fb978d6d: when a subscription is added for a repo we extract the package name and store it with the subscription object and from that time on every publish operation checks the package being published against the expected name.

The test exploit the ability of meteor show to discover whether the current folder contains sources for the package queried for. As an example, if I run meteor show useraccounts:core from the source folder I get:

Package: useraccounts:core@local              
Maintainers: useraccounts                     
Git: https://github.com/meteor-useraccounts/core.git
Exports: AccountsTemplates                    
Implies: accounts-base, softwarerero:accounts-t9n, templating (web.browser, web.cordova)

[![Meteor Icon](http://icon.meteor.com/package/useraccounts:core)](https://atmospherejs.com/useraccounts/core)
[![Build Status](https://travis-ci.org/meteor-useraccounts/core.svg?branch=master)](https://travis-ci.org/meteor-useraccounts/core)

Recent versions:                              
  1.12.2  August 17th, 2015     installed     
  1.12.3  August 21st, 2015     installed
  1.12.4  October 10th, 2015    installed
  1.13.0  December 5th, 2015    installed
  1.13.1  December 13th, 2015   installed
  1.13.1  /home/luca/Projects/UserAccounts/ui/core

differently I only get:

Package: useraccounts:core@1.13.1             
Maintainers: useraccounts                     
Git: https://github.com/meteor-useraccounts/core.git
Exports: AccountsTemplates                    
Implies: accounts-base, softwarerero:accounts-t9n, templating (web.browser, web.cordova)

[![Meteor Icon](http://icon.meteor.com/package/useraccounts:core)](https://atmospherejs.com/useraccounts/core)
[![Build Status](https://travis-ci.org/meteor-useraccounts/core.svg?branch=master)](https://travis-ci.org/meteor-useraccounts/core)

Recent versions:                              
  1.12.2  August 17th, 2015     installed     
  1.12.3  August 21st, 2015     installed
  1.12.4  October 10th, 2015    installed
  1.13.0  December 5th, 2015    installed
  1.13.1  December 13th, 2015   installed

for autopublish I'm checking we get the pwd among the results... But we could also check we get, e.g., Package: useraccounts:core@local and not Package: useraccounts:core@1.13.1 in the first line...

tredondo commented 8 years ago

Received from sangeeth5320/meteor-notifications to be revised!

@sangeeth5320, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from skys215/bootstrap-material-datetimepicker to be revised!

@skys215, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from CylonCourt/autoform-uikit to be revised!

@djenniex, thank you for testing autopublish: could you explain how you would like to use it?

splendido commented 8 years ago

@sangeeth5320 the package name inside your package.js is still gfk:notifications wich is an already published package. I cannot approve this subscription unless you change package name and re-subscribe... I'm sorry.

splendido commented 8 years ago

@skys215 are you trying to wrap T00rk/bootstrap-material-datetimepicker? We usually keep wrapper packages under MeteorPackaging. Would you like to move the repo over there?

splendido commented 8 years ago

@djenniex approved!

Edit: actually there's no subscription for your repo at the moment (only the record of a trigger got from a webhook...). Are you still interested in this?

tredondo commented 8 years ago

Received from formly-js/angular-formly to be revised!

@kentcdodds, thank you for testing autopublish: could you explain how you would like to use it?

kentcdodds commented 8 years ago

CCing Kamil Kisiela who requested I add it :-)

On Sat, Jan 2, 2016 at 8:52 PM Meteor publish bot notifications@github.com wrote:

Received from formly-js/angular-formly https://github.com/formly-js/angular-formly to be revised!

@kentcdodds https://github.com/kentcdodds, thank you for testing autopublish: could you explain how you would like to use it?

— Reply to this email directly or view it on GitHub https://github.com/MeteorPackaging/autopublish.meteor.com/issues/10#issuecomment-168457223 .

Kent C. Dodds https://twitter.com/kentcdodds

tredondo commented 8 years ago

Received from formly-js/angular-formly-templates-bootstrap to be revised!

@kentcdodds, thank you for testing autopublish: could you explain how you would like to use it?

kamilkisiela commented 8 years ago

@zimme These are the packages I was previously talking about.

Could you turn on Autopublish option on them?

zimme commented 8 years ago

@kamilkisiela all formly packages from you and formly-js have been approved, I couldn't find formly-js/angular-formly though.

kamilkisiela commented 8 years ago

@zimme so now it's like this?

[x] formly-js/angular-formly-templates-material
[x] formly-js/angular-formly-templates-bootstrap
[ ] formly-js/angular-formly

zimme commented 8 years ago

Hooks

[x] formly-js/angular-formly-templates-material
[ ] formly-js/angular-formly-templates-bootstrap
[ ] formly-js/angular-formly
[x] wieldo/angular-formly-transformer
[x] wieldo/angular-formly-validator
[x] wieldo/meteor-autoformly

Subscriptions

[x] formly:angular-formly-templates-material
[x] wieldo:angular-formly-transformer
[x] wieldo:angular-formly-validator
[x] wieldo:autoformly

kamilkisiela commented 8 years ago

@zimme I see the problem. I asked Kent to add webhooks only. He has the rights of those packages.

Is there a way to enable it so he wouldn't have to create an account on autopublish.meteor.com?

splendido commented 8 years ago

@kamilkisiela in case Kent is really not comfortable in creating an account, we can manually add a subscription object into the DB...

kamilkisiela commented 8 years ago

@splendido sure, if it's not a problem.

splendido commented 8 years ago

@kamilkisiela now we have all the following subscriptions and hooks approved:

formly-js/angular-formly (hook id 6823229)
formly-js/angular-formly-templates-bootstrap (hook id 6823233)
formly-js/angular-formly-templates-material (hook id 6684594)
wieldo/angular-formly-transformer (hook id 6709813)
wieldo/angular-formly-validator (hook id 6709809)
wieldo/meteor-autoformly (hook id 6708648)

please try to publish a new version for the packages you still have to test hooks for at your earliest convenience and let me know about any problems.

tredondo commented 8 years ago

Received from maximummeteor/computed-fields to be revised!

@maxnowack, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from FBRTMaka/meteor-arcgis to be revised!

@FBRTMaka, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from FBRTMaka/meteor-arcgis to be revised!

@FBRTMaka, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from newswim/particlesjs-meteor to be revised!

@newswim, thank you for testing autopublish: could you explain how you would like to use it?

newswim commented 8 years ago

@meteorpublish, I had a previous version which wasn't set up for autopublish -- attempting it again so I can learn the set-up and bring more libs in this system.

zimme commented 8 years ago

@newswim, I can't approve anything until you have the package setup properly, I don't see any package.js file in the repo and so on.

zimme commented 8 years ago

@maxnowack, approved.

tredondo commented 8 years ago

Received from jaaaco/mathjs to be revised!

@jaaaco, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from jaaaco/mathjs to be revised!

@jaaaco, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from tamino-martinius/meteor-smart-record to be revised!

@tamino-martinius, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from brandonparee/meteor-metadisk to be revised!

@brandonparee, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from brandonparee/meteor-metadisk to be revised!

@brandonparee, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from benjick/meteor-telegram-bot to be revised!

@benjick, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from rgnevashev/select2 to be revised!

@rgnevashev, thank you for testing autopublish: could you explain how you would like to use it?

tredondo commented 8 years ago

Received from rgnevashev/collection-taggable to be revised!

@rgnevashev, thank you for testing autopublish: could you explain how you would like to use it?

MeteorPackaging / autopublish.meteor.com

New Hooks to be approved #10