search

MeteorPackaging / autopublish.meteor.com

Test application to automatically setup GitHub repositories containing Meteor packages to be auto-published on new releases with TravisCI
https://autopublish.meteor.com/
MIT License
17 stars 0 forks source link

Refactor of toggle buttons #20

Open splendido opened 9 years ago

splendido commented 9 years ago

I'm thinking to start a refactor of the code to end up showing three different toggle buttons.

  1. enable auto-publish (for repositories containing a Meteor package)
  2. simple webhook creation (for 3rd party library we're going to wrap)
  3. enable auto-publish for repo with wrapped packages (which is: repository being under MeteorPackages and including a autopublish.json file..)
dandv commented 9 years ago

Button #1 seems like an easy convenience, right? It would only save authors from running meteor publish after git push, if I understand correctly.

For #3, did you mean "repo with wrapped packages", i.e. multiple packages?

splendido commented 9 years ago

yeah, n.1 would be for private packages (would we really like to support this?) n.3 would be for our repositories wrapping 3rd party libraries like snapsvg-wrapper to cite the latest one...

zimme commented 9 years ago

I use autopublish for all my packages, but I guess I could do manual meteor publish whenever I release

splendido commented 9 years ago

@zimme it's fine you use autopublish! ...you're giving a bunch of valuable feedbacks this way, so please do use it.

The question:

would we really like to support this?

is more for the long term, just in case too many people started to use it for private packages.

I already have a list of hooks with their own approval status, but I'm actually ignoring it when receiving triggers... We might think to really consider approvals... but this would mean having someone taking care of new subscription requests, which means time... ...perhaps in case MDG will show some more interest on this ;-)

Btw, I've just turned users @zimme and @dandv admin users so you can view some more button... :-)

zimme commented 9 years ago

:+1: