search

MeteorPackaging / discussions

Ask for Meteor integration help, or discuss Meteor 3rd party library packaging
5 stars 1 forks source link

is.js #19

Open xumx opened 9 years ago

xumx commented 9 years ago

I would like to try integrating this library. Please fork.

https://github.com/arasatasaygin/is.js/

splendido commented 9 years ago

Hello @xumx! I've just forked the repo and added you to the isjs team

To proceed you can try to follow the wiki to get an official integration, or try with the new sister repo approach me and @dandv are trying to investigate.

splendido commented 9 years ago

There's already an isjs organization on Atmosphere... ...was it you @dandv?

splendido commented 9 years ago

...wooops, I've just discoverd I'm already a member of isjs and @xumx is too! So I guess it was defenitely @dandv ;-)

xumx commented 9 years ago

I created that atmosphere organization. I followed the wiki and the packaging is successful. published at https://atmospherejs.com/isjs/is

Not sure how to get autopublish.meteor.com to work though. I logged in with my github account and there is nothing. No repository to work with.

splendido commented 9 years ago

Ok, so it wasn't @dandv ;-)

...It's the original author that is supposed to turn on autopublish.meteor.com to get automated publishes, but this can't happen before he merges a PR to get real official integration

splendido commented 9 years ago

The only thing I'm concerned about is that the forked repo expects the author to publish the package from his machine: see here

This is not what we were originally saying in the step by step guide at points 8 and 9... There must have been some mistakes putting in a wrong link. I'm sorry for this.

I've just updated point 9.

splendido commented 9 years ago

But there's no task within the Gruntfile to update the version number... ...so my guess is it's done by hands. :(

Lets have a look here to get an example of a task to update version numbers.

What about proposing this to the author? ...after manual update of version number inside package.json all other files (bower.json, package.js, etc.) will be updated automatically