search

Meteox / roll20-character-sheets

Character sheet templates created by the community for use in Roll20.
MIT License
4 stars 1 forks source link

Translations doesn't appear in the roll results #29

Closed dyvim closed 4 years ago

dyvim commented 4 years ago

For the moment when you make a roll with this sheet the text that appears is still in german despite the fact that almost all the terms have been translated in other languages (english and french).

It is caused by the fact that the attribute "name" that is dipslayed in the rolltemplates is the original german name and not its translation. The DSA 5 Tsa Edition does it correctly.

In fact for each roll in the sheet you have something like that <button type="roll" value="@{output_option} &{template:DSA-Zauber} {{name=Hexagramma}} when you need something like that <button type="roll" value="@{output_option} &{template:DSA-Zauber} {{name=^{Hexagramma}}}

@mckee14 can you do something about that?

mckee14 commented 4 years ago

I replaced all the (button type="roll") Rolls accordingly. It works, but it seems some things are not translated yet. Inside of the roll templates are other strings not translated, like "Verteidigungswurf: gelungen". From what I understand, this is correct in the HTML file, but the tags are just missing the translation.

If there is more I need to correct, let me know. I will update the pull request right now.

dyvim commented 4 years ago

Great! I'll check that ASAP (probably on tuesday when your push will be commited)

dyvim commented 4 years ago

Hello. It works now. We can see correctly the translation of the skill name. @mckee14 I'll close the issue but if you have the time, there are lots of other terms in the rolls that need to get their correct translation...