MethanePowered / MethaneKit

🎲 Modern 3D graphics made simple with C++17 cross-platform framework and rendering abstraction API on top of DirectX 12, Metal & Vulkan
Apache License 2.0
880 stars 54 forks source link

Sonar: set METHANE_VERSION_BUILD=0 to benefit from SonarCloud analysis cache #117

Closed mpaladin closed 1 year ago

mpaladin commented 1 year ago

Having METHANE_VERSION_BUILD changing at each run invalidates the analysis cache, losing its benefit and leading to a full cache miss at each run.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (75f37fa) 29.98% compared to head (a91ab13) 29.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #117 +/- ## ======================================= Coverage 29.98% 29.98% ======================================= Files 393 393 Lines 23370 23370 Branches 1979 1979 ======================================= Hits 7004 7004 Misses 16225 16225 Partials 141 141 ``` | Flag | Coverage Δ | | |---|---|---| | linux | `25.25% <ø> (ø)` | | | macosx | `44.50% <ø> (ø)` | | | unittests | `29.98% <ø> (ø)` | | | windows | `25.89% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MethanePowered#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MethanePowered). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MethanePowered)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.