MethanePowered / MethaneKit

🎲 Modern 3D graphics made simple with C++17 cross-platform framework and rendering abstraction API on top of DirectX 12, Metal & Vulkan
Apache License 2.0
880 stars 54 forks source link

Fix wrong comment encoding #120

Closed gukazma closed 1 year ago

gukazma commented 1 year ago

When compiling with Visual Studio, the error message This file contains characters that cannot be represented in the current code page (936). Please save the file as Unicode format to prevent data loss. indicates that special encoding format is used in the comments.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (03e21b4) 29.98% compared to head (ffdecfe) 29.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #120 +/- ## ======================================= Coverage 29.98% 29.98% ======================================= Files 393 393 Lines 23370 23370 Branches 1979 1979 ======================================= Hits 7004 7004 Misses 16225 16225 Partials 141 141 ``` | Flag | Coverage Δ | | |---|---|---| | linux | `25.25% <ø> (ø)` | | | macosx | `44.50% <ø> (ø)` | | | unittests | `29.98% <ø> (ø)` | | | windows | `25.89% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MethanePowered#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/MethanePowered/MethaneKit/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MethanePowered) | Coverage Δ | | |---|---|---| | [...s/Sources/Methane/UserInterface/HeadsUpDisplay.cpp](https://app.codecov.io/gh/MethanePowered/MethaneKit/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MethanePowered#diff-TW9kdWxlcy9Vc2VySW50ZXJmYWNlL1dpZGdldHMvU291cmNlcy9NZXRoYW5lL1VzZXJJbnRlcmZhY2UvSGVhZHNVcERpc3BsYXkuY3Bw) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

egorodet commented 1 year ago

Hello @geekgary-x, thank you for the fix. As I see the file is already saved in UTF-8 encoding, which should properly support that pseudo-graphics symbols. While I don't fully understand why VS and Windows with Chinese encoding set by default denies to compile it, I agree to fall back to ASCII as a bullet-proof solution 😄