search

MethodicalAcceleratorDesign / MAD-NG

MAD Next-Generation official repository
GNU General Public License v3.0
32 stars 11 forks source link

adding tests for constructor #442

Closed 17IMMANUEL17 closed 5 months ago

17IMMANUEL17 commented 5 months ago

you can avoid to check the tpsa_fun.mad since it is just a copy of the old tests for the function you wrote. I just moved everything to another file.

ldeniau commented 5 months ago

First this PR concerns unit tests and not MAD-NG itself and we were supposed to review it together before you push it... Second you are naming bugs things that are not bugs so you commit titles are wrong and very negative. Third the MAD-NG API didn't changed on that point, you just misunderstood the difference between ord and maxord, and you used low-level operator method like __len which should be avoided, especially in unit tests. Four, the file containing ctors tests is not clean nor follows already established (in other files) coding convention for test suites.

The net result is that once more all notified users receive emails saying that you corrected bugs in MAD-NG, which is completely wrong...