MethodicalAcceleratorDesign / MAD-X

MAD-X repository
Other
48 stars 39 forks source link

KSI silently ignored for solenoids with L>0 #1147

Open rdemaria opened 1 year ago

rdemaria commented 1 year ago

SOLO: SOLENOID, L = 2., KSI = 0.001;

succeds but KSI is ignored

HelmutCERN commented 1 year ago

Dear Riccardo

This is as described in http://madx.web.cern.ch/madx/madX/doc/usrguide/Introduction/solenoid.html

Thick specify KS Thin specify both KS and KSI

Cheers, Helmut

On 19 Oct, 2022, at 12:04, Riccardo De Maria @.***> wrote:

SOLO: SOLENOID, L = 2., KSI = 0.001;

rdemaria commented 1 year ago

Madx is not preventing invalid input. Perhaps we should add that the ksi is not used for l>0 and issue a warning. Similarly it is not clear whether ks is needed for l=0. What about using Lrad like in orbit correctors instead of ksi?

HelmutCERN commented 1 year ago

Specifying thin solenoids with KSI and LRAD rather than KS and KSI would in fact be more similar to what’s used for example for correctors. If we agree on that I will be happy to update MAKETHIN to do this.

For backward compatibility KS, KSI should still be allowed

On 19 Oct, 2022, at 12:47, Riccardo De Maria @.***> wrote:

Madx is not preventing invalid input. Perhaps we should add that the ksi is not used for l>0 and issue a warning. Similarly it is not clear whether ks is needed for l=0. What about using Lrad like in orbit correctors instead of ksi?

— Reply to this email directly, view it on GitHub https://github.com/MethodicalAcceleratorDesign/MAD-X/issues/1147#issuecomment-1283804636, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUCRLVW3LUYCH7T5N5SAITWD7GSXANCNFSM6AAAAAARI6JZDU. You are receiving this because you commented.

rdemaria commented 1 year ago

I agree with your proposal!

HelmutCERN commented 1 year ago

Addressed by https://github.com/MethodicalAcceleratorDesign/MAD-X/pull/1179