MethodicalAcceleratorDesign / MAD-X

MAD-X repository
Other
49 stars 39 forks source link

ordering elements in save sequence not respected leading to bugs #683

Closed rdemaria closed 6 years ago

rdemaria commented 6 years ago

When saving an LHC sequence with a maker at the IP, I get

lhcb1: sequence, l = 26658.8832;
atlaspipe1.r1, at = 0, from = ip1;
ip1: omk, at = 0,apertype=circle,aperture:={0.029},aper_tol:={0.011};
atlaspipe2.r1, at = 0.36967, from = ip1;
...

which generate negative drifts.

ldeniau commented 6 years ago

After discussion with Riccardo, the important point is that the negative drift occurs after a CYCLE on IP1, i.e. the marker atlaspipe1.r1 “from" refers to IP1, which is at L from it after the cycle and the reported negative drift is of -L...

On 9 Oct 2018, at 11:41, Riccardo De Maria notifications@github.com<mailto:notifications@github.com> wrote:

When saving an LHC sequence with a maker at the IP, I get

lhcb1: sequence, l = 26658.8832; atlaspipe1.r1, at = 0, from = ip1; ip1: omk, at = 0,apertype=circle,aperture:={0.029},aper_tol:={0.011}; atlaspipe2.r1, at = 0.36967, from = ip1; ...

which generate negative drifts.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/MethodicalAcceleratorDesign/MAD-X/issues/683, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABKFz9AiwTsw21KfxI2LREiKo6_xpzKQks5ujG9hgaJpZM4XSiHh.

-- Laurent Deniau http://cern.ch/mad Accelerators Beam Physics mad@cern.chmailto:mad@cern.ch CERN, CH-1211 Geneva 23 Tel: +41 (0) 22 767 4647

tpersson commented 6 years ago

This is fixed in PR #686