Improve cmdlet Update-VSTeamAgent

MethodsAndPractices / vsteam

PowerShell module for accessing Azure DevOps Services and Azure DevOps Server (formerly VSTS or TFS)

https://methodsandpractices.github.io/vsteam-docs/

MIT License

448 stars 157 forks source link

Improve cmdlet Update-VSTeamAgent #278

Closed SebastianSchuetze closed 4 years ago

SebastianSchuetze commented 4 years ago

As discussed earlier with @DarqueWarrior the PR #273 is good, but some changes should be improved:

command should be renamed to Update-VSTeamAgentSoftware
also by default the cmdlet should give a warning as it does on the UI (see screenshot below). This means the SupportsShouldProcess should be added to the function so the -force flag has to be used to deactivate the confirmation manually
the related unit tests should be moved to an extra file named Update-VSTeamAgentSoftware.Tests.ps1

DarqueWarrior commented 4 years ago

I will take care of this today.

woehrl01 commented 4 years ago

Great improvement ideas! If you need help, just raise your hand.

DarqueWarrior commented 4 years ago

Thanks for the PR @woehrl01 I really appreciate the support. The changes are making their way through the pipeline now. Hope to have a new release soon.

SebastianSchuetze commented 4 years ago

This is done with one of the last releases, although we left the cmdlet name as it is. :-)