MethodsAndPractices / vsteam

PowerShell module for accessing Azure DevOps Services and Azure DevOps Server (formerly VSTS or TFS)

https://methodsandpractices.github.io/vsteam-docs/

MIT License

445 stars 155 forks source link

Enhance Get-VSTeamProcess #300 #322

Closed jhoneill closed 4 years ago

jhoneill commented 4 years ago

PR Summary

Get-VSTeamProcess now:

Gets information from the /work/processes URI path rather than process/processes as the former has additional details
Can query for processes using a wildcard name.
Updates when it runs the cached process information
Displays whether a process was disabled or is the default process.

PR Checklist

[X] [Write Help] (Small updates, mostly reflecting the different API provides more information but doesn't support paged responses)
[X] [Write Unit Test] (Fixed existing ones.)
[X] [Update CHANGELOG.md]

jhoneill commented 4 years ago

I do not want to change the build process in any way at this time.

I've changed my build so that

_Classes.json is as as you had it and vsteam.classes.ps1 gets built.
vsteam.psm1 dot sources vsteam.classes.ps1 as you had it
vsteam.psm1 is copied as is to the output directory, as you had it.

I have also added a switch to build module if specified

vsteam.psm1 in the output directory is appended to vsteam.classes.ps1
the now-extended vsteam.classes.ps1 is copied over vsteam.psm1.
vsteam.classes.ps1 will still be dot sourced so is replaced with "#Empty"

So have we can development that little bit easier with a build-time switch and the "normal" build process is unaffected.

I do not want any testing flags of any kind.

I found one last stray one in Add-VSTeamBuild.ps1 they are all removed from my branches now (I think) _edit / postscript I removed it wrong and broke the test. Doh! Fortunately I tested before pushing the commit.

DarqueWarrior commented 4 years ago

How are you merging the changes from upstream? I see 235 files changed but they really didn't it is making it very time consuming to review this PR.

jhoneill commented 4 years ago

How are you merging the changes from upstream? I see 235 files changed but they really didn't it is making it very time consuming to review this PR.

It was some time back... I think I pulled upstream into to my master branch and then merged master into this branch which had already been created for the PR.

DarqueWarrior commented 4 years ago

I should have these changes in today.

DarqueWarrior commented 4 years ago

Switching Get-VSTeamProcess from Processes to Work breaks TFS2017. I am working switching the call based on the API version being used. I will be merging these changes from another PR because there are too many files changed in this PR to make sense of the actual changes.