Closed speedmind closed 4 years ago
Thanks for reporting. We will check this.
@speedmind could you provide the fiddle request? That would help a lot. Do you have sensitive data in the fiddler request?
It does, but I'll invalidate my PAT... Please delete once downloaded. update: remove the download link
What was the special character in the users name? I want to setup a test environment to duplicate.
What was the special character in the users name? I want to setup a test environment to duplicate.
Hi Donovan, It's kind of strange. The character causing the issue is an unknown character \xEF\xBF\xBD (�) but the correct character should have been \xC3\xA1 (á)
If you have access to the fiddler session I uploaded, you'll see that the requests No. 11, 20, 23, 50 & 56 submit the wrong (�) character but the responses No. 8, 23 & 56 return the correct character (á).
You can find the offending character by looking at either the request or the response using xPath: $.artifacts[1].definitionReference.requestedFor.id
Either way, when the request is submitted with charset=utf-8
(it was added manually by me in fiddler) in the Content-Type (see requests No. 23 & 56) the server seems to be happy (as opposed to requests No. 20 & 60 which fail without it).
Hope this clarifies the situation and I appreciate you looking into this, Vas.
I have a copy of the Fiddler log. I will find time to review. Thanks.
I took a look and I can confirm that it is an encoding problem. Gonna fix it now.
fixing took a bit longer since I also implemented integration tests for this cmdlet. But PR is checked now and should go through.
Fix will be in 6.5.1
This issue is similar (if not identical) to #239 & #221 but is still present in the current release 6.4.8. Please note that no modifications are being made to the release, so it's effectively been submitted as it arrives.
This occurs whenever the JSON request contains special characters and in our case I've identified a user with a special character in his name in the request under artifacts/definitionReference/requestedFor/id, but it could have been anywhere...
I've tried on Windows locally, but it also fails consistently on a Linux hosted agent (ubuntu-18.04) on AzD.
I've also captured the whole communication using fiddler and can provide it upon request.
Steps to reproduce
These are essentially the steps provided in the Update-VSTeamRelease reference documentation here: https://github.com/DarqueWarrior/vsteam/blob/master/.docs/Update-VSTeamRelease.md
Expected behavior By modifying the Update-VSTeamRelease function locally I get the behavior below
Should return $r without any error similar to the one below
Actual behavior
Environment data
OS
Server