MethodsAndPractices / vsteam

PowerShell module for accessing Azure DevOps Services and Azure DevOps Server (formerly VSTS or TFS)
https://methodsandpractices.github.io/vsteam-docs/
MIT License
444 stars 155 forks source link

Fix Update-VSTeamUserEntitlement to correctly use contentype application/json-patch+json #430

Closed thahif closed 2 years ago

thahif commented 2 years ago

PR Summary

PR Checklist

thahif commented 2 years ago

@SebastianSchuetze - PR raised. Can you take it fwd from here?

SebastianSchuetze commented 2 years ago

@thahif could you check that you allowed me to make updates in your branch as a maintainer?

Otherwise you would need to update the changelog.md in the same way like the other entries. Your change would fit in version 7.5.0

image

thahif commented 2 years ago

@SebastianSchuetze - I see that you can edit my branch.

image

SebastianSchuetze commented 2 years ago

Strange. I can't edit the branch.

thahif commented 2 years ago

@SebastianSchuetze - what do we next? I have re-applied that allow edit by maintainers permission. Can you please check?

SebastianSchuetze commented 2 years ago

If not then I will use your branch in one of mine and merge that one. This I would close then.

thahif commented 2 years ago

@SebastianSchuetze - Any timeline that you can comment when this will be available to download?

SebastianSchuetze commented 2 years ago

I will try my best but first I need to solve this #424 and it is usually happening outside of my worktime. So no ETA I can only try to give my best. Even if I merge it it will not be available before release works.

SebastianSchuetze commented 2 years ago

But you might want to check the cmdlet Invoke-VSTeamRequest which allows you to address any API of AzDO with your own custom JSON body. In that way you might have a work around in the mean time.

You just need to handle the API yourself a bit. Or even copy the code and reuse it with this command.

SebastianSchuetze commented 2 years ago

I solved finally the problem with the workflow.... or at least nearly. I will be working on your PR and merge it as soon as possible.