Closed rbleattler closed 1 year ago
@SebastianSchuetze do I need to re-submit with SupportsShouldProcess implemented?
What do you mean resubmit? You can just keep editing your branch until everything is fine. You didn't need to close the PR and reopen one.
Just commit here until everything is fine. At the end we do a squash merge anyways.
Thanks, I learn something new every day. I'll try to get this updated on Monday.
I believe everything that needed to be fixed has been fixed, including adding support for SupportsShouldProcess / -WhatIf
I removed some lines in the changelog because it is not interesting if there are typo changes. Only real changes for somebody using the modules is interesting. E.g. bug fixes or new features in cmdlets or the documentation of the cmdlets themselve.
approved and merged. Thanks very much!!
PR Summary
PR Checklist