MethodsAndPractices / vsteam

PowerShell module for accessing Azure DevOps Services and Azure DevOps Server (formerly VSTS or TFS)
https://methodsandpractices.github.io/vsteam-docs/
MIT License
442 stars 155 forks source link

Set-VSTeamVariableGroupVariable cmdlet, tests, docs #495

Closed sevaa closed 1 year ago

sevaa commented 1 year ago

PR Summary

Addresses #423

PR Checklist

sevaa commented 1 year ago

Addressed most. Please take another look.

sevaa commented 1 year ago

What are my next steps, please?

The group search by name is broken (obscure exception if not found), the double JSON convert can be avoided but the review doesn't say so, just asks why.

sevaa commented 1 year ago

Is this PR a lost cause? If so, please let me know. As outlined in #423, I'll go ahead and publish as a separate PowerShell module.

sevaa commented 1 year ago

Any update please? Any maintainers present? I think I've made all the changes needed - but the PR still says "Changes requested". @SebastianSchuetze @DarqueWarrior

sevaa commented 1 year ago

@SebastianSchuetze What should be my actions now?

SebastianSchuetze commented 1 year ago

Thanks for the help! Gonna merge it.