MethodsAndPractices / vsteam

PowerShell module for accessing Azure DevOps Services and Azure DevOps Server (formerly VSTS or TFS)
https://methodsandpractices.github.io/vsteam-docs/
MIT License
442 stars 155 forks source link

Powershell 5 compatibility for Build-Module.ps1 #496

Closed sevaa closed 1 year ago

sevaa commented 1 year ago

PR Summary

Encoding UTF8BOM for Set-Content was not available is PS5. This PR makes the encoding value conditional.

The readme states the lower bound of Powershell compatibility at 5.

The only way to test that is to introduce an explicitly PS5 build in the CI scripts. That's a maintainer level decision.

The CI will fail over the Update-VSTeamProject autotest issue. Only merge when/if either #494 or #495 lands.

PR Checklist

sevaa commented 1 year ago

Told you so :)

SebastianSchuetze commented 1 year ago

I can only merge when the test do not fail.

sevaa commented 1 year ago

Builds now.