MethodsAndPractices / vsteam

PowerShell module for accessing Azure DevOps Services and Azure DevOps Server (formerly VSTS or TFS)
https://methodsandpractices.github.io/vsteam-docs/
MIT License
442 stars 155 forks source link

Get-VSTeamVariableGroup doesn't urlencode the group name #517

Closed sevaa closed 1 year ago

sevaa commented 1 year ago

Steps to reproduce

Get-VSTeamVariableGroup -Project "MyProject" -Name "a&b"

Expected behavior

I expected that the variable group contents would be returned as a PSObject

Actual behavior?

Three exceptions in a row.

This is a bigger issue than just Get-VSTeamVariableGroup; chances are other cmdlets that take a string parameter that goes directly into the API don't URLEncode them either.

On Which OS have you tried it?

Windows

What was your server version?

Azure DevOps Server 2020

Other server version

No response

Log output of used API

Billing                     :
Build                       : 5.0
Core                        : 5.0
DistributedTask             : 5.0-preview
DistributedTaskReleased     :
ExtensionsManagement        : 5.0-preview
Git                         : 5.0
Graph                       :
HierarchyQuery              : 5.0-preview
MemberEntitlementManagement :
Packaging                   : 5.0-preview
Pipelines                   :
Policy                      : 5.0
Processes                   : 5.0-preview
Release                     : 5.0
ServiceEndpoints            : 5.0-preview
TaskGroups                  : 5.0-preview
Tfvc                        : 5.0
VariableGroups              : 5.0-preview
Version                     : AzD2019
Wiki                        : 5.0
WorkItemTracking            : 5.0

Log output of $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.2673
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.2673
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
mnieto commented 1 year ago

@sevaa, @SebastianSchuetze this bug is fixed with #523 and can be closed