Closed veryeasily closed 3 years ago
Any updates?
Is this fix confirmed to be working?
Is this fix confirmed to be working?
Yes, it does fix the error reported in #284. While waiting for the pull request to be accepted I forked the repo and pushed a custom build of the plugin, because I needed it asap.
Thanks! I think I find myself in the same boat.
Thanks! I think I find myself in the same boat.
Actually, I forgot to add that the typings are also broken, if you're using Typescript.
The absolute minimum required to get everything to work is a definition of the custom properties:
declare module '@vue/runtime-core' {
interface ComponentCustomProperties {
$socket: SocketIO.Socket,
}
}
I placed this declaration in my app entrypoint. I found this solution on stackoverflow.
Any updates?
@MetinSeylan could you merge it please?
Happy to see this merged too.
thanks for merging! I tried running npm update vue-socket.io and it still doesn't seem to be working
@wkuinkc try changing your dependency to point to this repo instead of the npm package; the latest release goes back to August of last year
@MetinSeylan, the NPM version doesn't seem up to date. Is there an upcoming update ? It would be greatly appreciated !
This pull request adds Vue 3 compatibility which should fix #284.
Previously this fix was open as #287 but seems like it was maybe prematurely closed. I tested my changes out and they appear to work on both Vue 3 and Vue 2.
As a warning though, my vue 3 tests have not been super thorough because my application is having vue 3 problems with unrelated dependencies. This PR gets past the initial issue, but there may still be deeper problems to debug.