MetricsDAO / harmony_dbt

DBT Project for the Harmony Blockchain

12 stars 8 forks source link

add sequence, gap tests #128

Closed 0xissui closed 2 years ago

0xissui commented 2 years ago

Description

Adding sequence gap tests for blocks and transaction gap tests for txs. Updated block_number to block_id in txs.

Tests

dbt run

dbt test

Notes: 700k+ warnings seem to be gone in prod, tx_gaps not though

Checklist

[ ] Follow dbt style guide
[ ] Tag the person(s) responsible for reviewing proposed changes
[ ] Notes to deployment, if a full-refresh is needed for any table - full refresh done for txs so downstream may need refreshes
[ ] Run dbt docs generate to update the documentation files if this PR is changing the models in any way.

netlify[bot] commented 2 years ago

Deploy Preview for mdao-harmony canceled.

Name	Link
Latest commit	47dd10e130d2e12ca761baea319713a39215dcc8
Latest deploy log	https://app.netlify.com/sites/mdao-harmony/deploys/62a0d47868bb820008782e45

antonyip commented 2 years ago

Hey @0xissui.

Just leaving a note here stating that I don't approve of this... due to..

Introducing test cases warnings without fixing them on dev is just going to confuse other people.
block_number change to block_id on the txs table is going to require a full-refresh in the whole database and break everything that I have.
gap test cases are just useless to us because there is no recourse even when it gets triggered and will just spam my email box.

chuxinh commented 2 years ago

block_number change to block_id on the txs table is going to require a full-refresh in the whole database and break everything that I have.

probably not that bad but definitely need rebuild of tx and also dfk_seed_harvests

antonyip commented 2 years ago

block_number change to block_id on the txs table is going to require a full-refresh in the whole database and break everything that I have.

probably not that bad but definitely need rebuild of tx and also dfk_seed_harvests

Sadly... Its stuffs thats outside of this repo that may break due to txs change such as my harmony dashboard / and all my cicd stuffs.. already went though that once with the ingested_at changes.

forgxyz commented 2 years ago

Some conversation, but otherwise lgtm