Open elisemarika opened 1 year ago
@nftchance or @masonchain any strong opinions/nuances to be aware of with the requirements here?
I think this makes sense to have and all your requirements outline it well. None of this has to be on chain or actually impact the protocol or chain at all. Reviews and comments could be stored on IPFS and their hashes in the app db.
If we did want to include writing the IPFS hash of a review when a reviewer does grade a submission, that is entirely possible. Any other comment should definitely not be written to the chain though.
@nftchance What do you think? Worth including in the function and event?
If we did want to include writing the IPFS hash of a review when a reviewer does grade a submission, that is entirely possible. Any other comment should definitely not be written to the chain though.
Sure, sounds good to me. Easy to justify -- Allows someone to query the whole state of the protocol which is pretty cool so why not!
"Users can optionally leave comments on submissions they score" - in our existing system we made it as mandatory as several reviewers were marking posts as spam without giving any explanation. Also few reviewers mark a submission as excellent or very bad without any context. It will be helpful if we have option to mark comments as mandatory. Preferably configurable while launching the challenges.
Also please consider ability to upload proofs like screenshots so that reviewers are empowered to backup their claims on plagiarized posts, empty dashboards, etc.
I agree with kakamora that it should probably be mandatory to include comments. Ideally, submitting a comment should be in the same step as submitting a score during the review process (the less interactions to get reviews done the better)
@thekakamora @ltirrell super helpful, thank you. please share feedback on this updated set too
For being able to add comments in isolation and replying to others: i think these may be nice-to-haves. i think these may be more like a general commenting system, than a key part of review. it's useful to have it here, but could potentially happen elsewhere.
related, maybe a user can add twitter/discord information when they submit so people can communicate with them about their submission in another forum.
If leaving comments outside of reviews is an onchain txns, I'm not sure how many will be willing to comment. Nonetheless I think it is helpful to keep the comments / replies open for everyone so that community can collaborate & debate when necessary.
Users can only leave comments when scoring submissions << or should they also be able to in isolation - I vote for ability to leave comments on isolation.
Analysts can only reply to comments left on their own submission << or should they also be able to reply to other comments . I vote for "be able to reply to other comments"
I agree with @thekakamora and @ltirrell generally.
Comments should exist at the app layer, not be onchain, and therefore not create friction in participation.
With this understanding, should comments simply be open to everyone? OR do we think it should be limited to participants? If so why?
Agree, reviewers should be required to comment ("rationale"). Unexplained bad reviews aren't constructive and can quickly breed ill will to the whole system.
Anyone should able to comment and reply. Discussion is how a community learns together.
Elise/Drake 4/11 (let's not build a forum)
Testing - providing community feedback to illuminate an issue
It works! I'll start providing examples of community feedback that highlight the importance/prioritization of specific issues.
Dev ready Submissions page with Drawer comments and scoring. Figma link
fyi @sebruiz @thehannahlerman moving this one into ready for dev :)
This will utilize the URI on Reviews in V2!
Job to be Done As a Reviewer in the Metrics app, I want to be able to leave comments on other analysts' submissions when scoring them, so I can provide more feedback/suggestions/reasoning relating to the score I give them during peer review, and help them learn/grow as analysts and level up future submissions.
Requirements
Design
Ready for Dev: