Launch Challenge v2 - Githubissues

MetricsDAO / xyz

MetricsDAO XYZ Website

https://metricsdao.xyz

Apache License 2.0

12 stars 8 forks source link

Launch Challenge v2 #643

Open elisemarika opened 1 year ago

elisemarika commented 1 year ago

Requirements Claim to submit limit

Sponsor can set a max claim to submit limit to limit how many analysts can claim a challenge to submit

Total reviews limit

Sponsor can set a max reviews per challenge to limit how many scores are submitted for a single challenge in aggregate

Reward Token and Reward Pool for Reviewers

Sponsor can set and fund the reward token (pToken) and reward pool amount for Reviewers
Note: Sponsor needs to approve transfer of funds for both the analyst tokens and reviewer tokens (see tx UX)

Multi-step create flow

Sponsors have a multi-step launch Challenge flow like they'll have for create Marketplace once N Badge launches

Designs

drakedanner commented 1 year ago

With the introduction of Review pTOKEN, we now have 3 transactions

Approve Analyst pTOKEN Allowance
Approve Reviewer pTOKEN Allowance
Transfer Analyst pTOKEN & Transfer Reviewer pTOKEN

This flow reminds of an LP situation which we can review on Uniswap, Velodrome, and Sushiswap. Users also need to approve allowance on both tokens before transferring to the pool.

drakedanner commented 1 year ago

Looms of LP process on Sushi, Velodrome, and Univ3

sushi - https://www.loom.com/share/31a41dd905af4343893e984b84689cb4 velodrome - https://www.loom.com/share/6b21525faa6644d8b443c91010ad767e uni v3 - https://www.loom.com/share/93fca26a719448d8a3e5d6c444abb7ac

Sushi:

Keeps the modal the same but changes button text, a bit confusing?

Velodrome:

Uses their Transaction queue pattern which I am a big fan of. I've seen a similar pattern on Rabbithole v2

Uni v3:

Shows both Approvals as separate buttons, then removes them as they approve. A bit confusing?

masonchain commented 1 year ago

4 transactions ( @nftchance @masonchain catch me if it's 3.. do Provider and Reviewer pTOKEN go into different vaults or the same one?)

Regardless of whether it's the same vault the transfers of both tokens will be done in the transaction that sets up the challenge. So, it should be 3 if the pTokens are different. 2 if they are the same (e.g. USDC for reviewers and rewards).

elisemarika commented 1 year ago

still waiting on protocol dev but app team can start new UI as bandwidth allows until the new parameters are ready

drakedanner commented 1 year ago

Working on v2 enforcement and payments and have come across the reality that we cannot support unlimited Submissions or unlimited Reviews.

More here on why here: https://github.com/MetricsDAO/xyz/issues/661#issuecomment-1535360991

A4x1 commented 1 year ago

Updated UI to not show unlimited option.

Figma Link

drakedanner commented 1 year ago

@thehannahlerman @sebruiz

Flagging that #443 will impact these UIs as well

@A4x1 is making progress on these designs: https://www.figma.com/file/TVCoREiQSgnWg2J5qrHKP0/MDAO-App-v2?type=design&node-id=34-7235

Will notify when ready for dev (aiming for mid/end next week)