MetricsDAO / xyz

MetricsDAO XYZ Website
https://metricsdao.xyz
Apache License 2.0
12 stars 8 forks source link

update error page to just show "something went wrong!" #707

Open gnomadic opened 1 year ago

gnomadic commented 1 year ago

Right now we're showing full strack traces if there's an error - we can hide those behind a user friendly error page because the stack traces should still go to sentry.

A4x1 commented 1 year ago

Let me know how this works https://www.figma.com/file/xo32mL5Q9jRPVotbH6nv5h/MDAO-App-(Sandbox-%26-User-Testing)?node-id=6348%3A31369&t=IYzckA3UYB3Cwoco-1

gnomadic commented 1 year ago

hey that's awesome! figure we can use it for other types of errors too besides just 404?

A4x1 commented 1 year ago

hey that's awesome! figure we can use it for other types of errors too besides just 404?

Got it. Made the change 👍

gnomadic commented 1 year ago

https://www.figma.com/file/xo32mL5Q9jRPVotbH6nv5h/MDAO-App-(Sandbox-%26-User-Testing)?node-id=6352-31137&t=1kRLLF4Qlck192wI-0

thekakamora commented 1 year ago

@gnomadic as the issue is closed, I'm assuming the fix has been deployed. With that assumption I forced an error by messing with the submission id in URL. I'm able to see stack traces.

image

gnomadic commented 1 year ago

hey yeah it's not fixed yet, this issue is open, in the priority lane - it should get into active development soon

termaatFlipside commented 1 year ago

@gnomadic / @A4x1 Do we want to give a link to the discord or anything like that?

gnomadic commented 1 year ago

Eh I don't think so, most of the errors are a 404 or one that can be recovered with a refresh.