search

MetricsGrimoire / MailingListStats

Mailing List Stats is a command line based tool used to analyze mboxes
http://metricsgrimoire.github.com/MailingListStats/
GNU General Public License v2.0
38 stars 25 forks source link

Refactor remote url retrieval files #30

Closed gpoo closed 10 years ago

gpoo commented 10 years ago

Re-requesting a pull, now from a branch :-)

Make available only one method to retrieve a web resource, instead of one for parsing the html index and another one for the mbox.

In addition, added magic numbers to detect the file type by content, which is better than guessing by the subtype given by the web server (not always available).

@sduenas What do you think about this approach?

Any further change in the content retrieval can be done in one place, so we avoid duplication of code and, it seems to me that the logic gets simpler.

BTW, this stores the files ended with .gz as gzipped files.

gpoo commented 10 years ago

In conjunction to Pull #27 this also Fix #23

sduenas commented 10 years ago

@gpoo Great work! Thanks. Closed by 0222ee0bac636f2e8a2020358b480ff1306b7c66