AttributeError: 'str' object has no attribute 'append'

zugaldia commented 1 month ago

Got this error on my packages:

Exception occurred while running check_setup_py: 'str' object has no attribute 'append'
Traceback (most recent call last):
  File "/home/username/.local/bin/glint_ros", line 8, in <module>
    sys.exit(main())
  File "/home/username/.local/lib/python3.10/site-packages/ros_glint/main.py", line 140, in main
    if preview_changes(package, name, fne, len(pkgs) > 1):
  File "/home/username/.local/lib/python3.10/site-packages/ros_glint/main.py", line 77, in preview_changes
    fne(new_pkg)
  File "/home/username/.local/lib/python3.10/site-packages/ros_glint/glinters/python_setup.py", line 149, in check_setup_py
    package.setup_py.args['packages'].append(value)
AttributeError: 'str' object has no attribute 'append'

Packages in the setup.py file looks like this:

packages=find_packages(exclude=["test"]),

DLu commented 1 month ago

Alas, the setup.py parsing is a little more brittle than it could be. Is this a ROS 1 package or ROS 2?

zugaldia commented 1 month ago

ROS 2.

On Tue, Jun 18, 2024 at 11:34 AM David V. Lu!! @.***> wrote:

Alas, the setup.py parsing https://github.com/MetroRobots/ros_introspect/blob/main/src/ros_introspect/components/setup_py.py is a little more brittle than it could be. Is this a ROS 1 package or ROS 2?

— Reply to this email directly, view it on GitHub https://github.com/MetroRobots/ros_glint/issues/22#issuecomment-2176398150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABWNECMC2ZU7SFQ3IZ2LTZIBHPZAVCNFSM6AAAAABJABB6WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGM4TQMJVGA . You are receiving this because you authored the thread.Message ID: @.***>

-- Antonio Zugaldia Mobile Engineering @zugaldia

MetroRobots / ros_glint

AttributeError: 'str' object has no attribute 'append' #22