MetroidAdvRandomizerSystem / MARS-Fusion

Metroid Advance Randomizer System for Metroid Fusion
GNU General Public License v3.0
12 stars 4 forks source link

Prevent you from playing save files on the wrong seed #65

Open Miepee opened 2 months ago

Miepee commented 2 months ago

The saves should store a UUID+hash (which rdv can provide) and only let you start the save file if the UUID of the game matches that of the save file. If the uuid+hash of the game doesn't match the save, you should not be able to boot the save file. This is to prevent people accidentally playing the wrong seed and messing things up.

duncathan commented 2 months ago

is this a relevant problem? I thought save files for GBA games were typically associated with a specific ROM, rather than shared like in other RDV games

Miepee commented 2 months ago

It's probably not toooo likely to cause issues for now, but it is fairly easy to just rename a rom file. IDK if it's gonna cause any issues later down the line in MW so wanted to open that preemptively here. At least on my dev environment, where I name all my output files "output.gba" I did have accidentally opened the wrong save file a few times, but that's not a normal usecase anyway.