Metron-Project / metron

Django website for a comic book database
https://metron.cloud/
GNU General Public License v3.0
90 stars 7 forks source link

User profiles 💃 #54

Closed bpepple closed 3 years ago

bpepple commented 3 years ago

Add pages for user to change password and update profile. Fixes #52

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.53%.

Quality metrics Before After Change
Complexity 2.98 ⭐ 3.28 ⭐ 0.30 👎
Method Length 41.50 ⭐ 44.15 ⭐ 2.65 👎
Working memory 12.81 😞 11.23 😞 -1.58 👍
Quality 68.45% 🙂 70.98% 🙂 2.53% 👍
Other metrics Before After Change
Lines 154 191 37
Changed files Quality Before Quality After Quality Change
users/admin.py 62.13% 🙂 60.99% 🙂 -1.14% 👎
users/forms.py 82.21% ⭐ 81.72% ⭐ -0.49% 👎
users/models.py 100.00% ⭐ 100.00% ⭐ 0.00%
users/urls.py 76.28% ⭐ 66.76% 🙂 -9.52% 👎
users/views.py 64.56% 🙂 69.83% 🙂 5.27% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
users/views.py signup 7 ⭐ 112 🙂 22 ⛔ 47.15% 😞 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.