search

Metronix / gruvin9x

Automatically exported from code.google.com/p/gruvin9x
0 stars 0 forks source link

FightPhase FadeIN/OUT #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What Version of the firmware are you running?
1224 STD,SPKR

Find this by entering the global menu using [LEFT-LONG], then advance to
Menu 3 - VERSION. * Please record at least the SVN data, E.G: "trunk-r38"

*SVN: frsky-r1224
VERS:V1.2-gruvin
DATE:2011-11-20
TIME:13:01:56

What steps will reproduce the problem?
1. creating FlightPhases with Fade IN/OUT timers for ID0,1,2 switch
2. apply mixers with FlightPhases
3. try switch between FPs -> the changes was without fades.

What is the expected output? What do you see instead?
Switching between FlightPhases with FadeIN/OUT transition.

What version of the product are you using? On what operating system?
r1197

Please provide any additional information below.
see attached companion9x file

Original issue reported on code.google.com by gbir...@gmail.com on 20 Nov 2011 at 10:04

Attachments:

GoogleCodeExporter commented 9 years ago 
I did receive a message on RCGroups about a similar issue, or is it the same 
person?
I will take care of this one myself.
Bertrand.

Original comment by bson...@gmail.com on 20 Nov 2011 at 12:24

GoogleCodeExporter commented 9 years ago

Original comment by bson...@gmail.com on 20 Nov 2011 at 12:24

GoogleCodeExporter commented 9 years ago 
we are communicating together. thanks.

Original comment by gbir...@gmail.com on 20 Nov 2011 at 12:27

GoogleCodeExporter commented 9 years ago 
Also the Flight phases labels are wrong, as suggested in your example.

Original comment by bson...@gmail.com on 22 Nov 2011 at 2:00

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Forget my comment #5 please!

Original comment by bson...@gmail.com on 22 Nov 2011 at 3:56

GoogleCodeExporter commented 9 years ago 
Commited.

Original comment by bson...@gmail.com on 22 Nov 2011 at 10:15

GoogleCodeExporter commented 9 years ago 
FP labels are now OK. But FadeIN/OUT start transition with opposite direction, 
and then  jump to final destination value. Also Fade have a strong affect on 
second channel.

Original comment by gbir...@gmail.com on 23 Nov 2011 at 6:37

GoogleCodeExporter commented 9 years ago 
It's true that I did test only on c9x and on g9x simu. Time to check on the Tx. 
Same eepe file? What do you mean by second channel?

Original comment by bson...@gmail.com on 23 Nov 2011 at 8:56

GoogleCodeExporter commented 9 years ago 
Could you confirm that you did an svn update and recompile yourself? If yes, 
would it be possible you test on the simu (make simu PCB=STD; ./simu). Thanks!

Original comment by bson...@gmail.com on 23 Nov 2011 at 9:10

GoogleCodeExporter commented 9 years ago 
Oh I see. Could you send me an email as soon as you are ready to test? I can 
solve it quickly, if I am sure that you are ready to test just after the 
commit. I am working on another rewrite meanwhile...

Original comment by bson...@gmail.com on 23 Nov 2011 at 9:15

GoogleCodeExporter commented 9 years ago 
Yes I compile r1244 ant test it on Tx. Now I go try to play with simu.

Original comment by gbir...@gmail.com on 23 Nov 2011 at 9:24

GoogleCodeExporter commented 9 years ago 
Ok I do commit now the bug I see (a cast missing. on simu it's not a
problem because it's internally calculating on 32bits)

Original comment by bson...@gmail.com on 23 Nov 2011 at 9:26

GoogleCodeExporter commented 9 years ago 
Commited in r1245

Original comment by bson...@gmail.com on 23 Nov 2011 at 9:28

GoogleCodeExporter commented 9 years ago 
Please try it on TX. Now its better but still problem on CH2 where I don't have 
Fade or FlightPhase applied.

Original comment by gbir...@gmail.com on 23 Nov 2011 at 10:16

GoogleCodeExporter commented 9 years ago 
Understood. The calculation is wrong. All channels are smooth even if no 
FlightPhase is  applied to them. I will change the algorithm tomorrow.

Original comment by bson...@gmail.com on 23 Nov 2011 at 10:28

GoogleCodeExporter commented 9 years ago 
Completely rewriten and commited in trunk. Tested on TX. Still needed some more 
testing before I port the corrections to the stable frsky branch.

Original comment by bson...@gmail.com on 24 Nov 2011 at 8:46

GoogleCodeExporter commented 9 years ago 
ok I am starting to test it on TX.

BTW: I try compiling the simu, but no success, please help see attachment

Original comment by gbir...@gmail.com on 24 Nov 2011 at 9:08

Attachments:

GoogleCodeExporter commented 9 years ago 
You need the fox lib:
http://www.fox-toolkit.org/

Original comment by bson...@gmail.com on 24 Nov 2011 at 9:34

GoogleCodeExporter commented 9 years ago 
FYI this simu feature will be embedded inside c9x soon.

Original comment by bson...@gmail.com on 24 Nov 2011 at 9:35

GoogleCodeExporter commented 9 years ago 
it's amazing!!! Thank You. Who would like, try new attached file. 
For users: Good to know that when you use FightPhase on Mixer it is always in 
"replace" all other mixers, without aspect on "ADD" or "Multiply". but I think 
it is OK.

Original comment by gbir...@gmail.com on 24 Nov 2011 at 9:35

Attachments:

GoogleCodeExporter commented 9 years ago 
Please could you explain a little bit more your last remark. I don't understand 
it, sorry!

Original comment by bson...@gmail.com on 24 Nov 2011 at 9:45

GoogleCodeExporter commented 9 years ago 
my misunderstanding I had all mixes in FP0,1,2 modes. I switched between them. 
If I have two mixes in the same FPx or some mixes in no FP mode, then there is 
mormal Add/multiply/replace behavior. sorry.

Original comment by gbir...@gmail.com on 24 Nov 2011 at 10:01

GoogleCodeExporter commented 9 years ago 
Perfect. Correction ported in frsky release candidate version (candidate for a 
2-weeks-without-a-bug test).

Original comment by bson...@gmail.com on 24 Nov 2011 at 10:17

GoogleCodeExporter commented 9 years ago

Original comment by bson...@gmail.com on 24 Nov 2011 at 10:18