Open pierre-eliep-met opened 2 years ago
Not relevant since loopcloser are purely mathematical artefacts while pressure cuts and heat losses are used for modeling purposes.
Sorry to get back to that @valentind-met but I discussed it with Nathalie, who said that they did not find a loop closer for enthalpy, but we actually have one, it's just that it is not clear where it is. Whereas if we had a subpackage of pipes, like Cuts
we could explicitly put FlowCut, PressureCut and HeatCut. This would make the library more explicit and more user friendly, with less learning time
I know you said that pressure cuts are different from loopclosers, but in a lot of cases we use it the same : a quantity is imposed on both sides and we need to add a degree of freedom.
Is your refactoring request related to a problem? Please describe. Currently we have separate components that are not very easy to read to cut a quantity propagation :
HeatLoss
to cut enthalpy/temperature propagationPressureCut
for pressureLoopBreaker
for flowDescribe the solution you'd like This should be more uniform, and not in pipes but in a dedicated package like
WaterSteam.LoopBreakers
orWaterSteam.QuantityCuts
and thenHeatCut
orHeatLoopBreaker
to cut enthalpy/temperature propagationPressureCut
orPressureLoopBreaker
for pressureFlowCut
orFlowLoopBreaker
for flowTo be checked by issue author