Metroscope-dev / metroscope-modeling-library

Modelica library to build physical models of nuclear and combined cycle gas power plants. Based on ThermoSysPro library
https://www.metroscope.tech/
Other
26 stars 1 forks source link

[Refacto]: Cuts (PressureCut, FlowCut, HeatCut) should be in a dedicated Medium.Cuts #272

Open pierre-eliep-met opened 2 years ago

pierre-eliep-met commented 2 years ago

Is your refactoring request related to a problem? Please describe. Currently we have separate components that are not very easy to read to cut a quantity propagation :

Describe the solution you'd like This should be more uniform, and not in pipes but in a dedicated package like WaterSteam.LoopBreakers or WaterSteam.QuantityCuts and then

To be checked by issue author

valentind-met commented 1 year ago

Not relevant since loopcloser are purely mathematical artefacts while pressure cuts and heat losses are used for modeling purposes.

pierre-eliep-met commented 1 year ago

Sorry to get back to that @valentind-met but I discussed it with Nathalie, who said that they did not find a loop closer for enthalpy, but we actually have one, it's just that it is not clear where it is. Whereas if we had a subpackage of pipes, like Cuts we could explicitly put FlowCut, PressureCut and HeatCut. This would make the library more explicit and more user friendly, with less learning time

I know you said that pressure cuts are different from loopclosers, but in a lot of cases we use it the same : a quantity is imposed on both sides and we need to add a degree of freedom.