This PR fixes the pressure loss complexity by using the inlet density instead of the mean density. Mean density created a complexity in which the pressure drop depends on the temperature, which creates a non desired causality possibility. This change is done in Pipes, ControlValves and SlidingValves.
No variables were deleted from the library, so the changes are transparent in terms of convergence (unless the model was using this weird causality).
For already calibrated models, results will slightly change. Most tests of the library were not significantly impacted by this, except some control valves of the steam turbine. This is therefore considered a breaking change but could be transparent for most models.
Fix #427
Type of change
[ ] Bugfix
[ ] New feature
[x] Refactoring change
[ ] Release & Version Update (don't forget to change the version number in package.mo)
Will it break anything in previous models ?
[x] Breaking change (See above)
[ ] Non-Breaking change
Checklist
[x] I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
[x] I have performed a self-review of my own code
[x] I have checked that all existing tests pass.
[x] I have added/updated tests that prove my development works and does not break anything.
[x] I have made corresponding changes or additions to the documentation (in Notion documentation)
[x] I have added corresponding entries to the Changelog
[x] I have checked for conflicts with target branch, and merged/rebased in consequence
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.
Goal
This PR fixes the pressure loss complexity by using the inlet density instead of the mean density. Mean density created a complexity in which the pressure drop depends on the temperature, which creates a non desired causality possibility. This change is done in Pipes, ControlValves and SlidingValves.
No variables were deleted from the library, so the changes are transparent in terms of convergence (unless the model was using this weird causality).
For already calibrated models, results will slightly change. Most tests of the library were not significantly impacted by this, except some control valves of the steam turbine. This is therefore considered a breaking change but could be transparent for most models.
Fix #427
Type of change
package.mo)Will it break anything in previous models ?
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.