Metroscope-dev / metroscope-modeling-library

Modelica library to build physical models of nuclear and combined cycle gas power plants. Based on ThermoSysPro library
https://www.metroscope.tech/
Other
27 stars 1 forks source link

Added pi to constants and Length to Units #465

Closed nabily-met closed 1 year ago

nabily-met commented 1 year ago

Goal

Added pi as a constant and Length as a unit. No need to add in changelog.

Resolves #464

Type of change

Will it break anything in previous models ?

Checklist

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

nabily-met commented 1 year ago

Could clean up all unnecessary annotation changes before you merge ? I guess only the Constants package should be modified

These are empty lines that has been automatically deleted by dymola. Do you think I should re-add them? It's only the constants package that has been modified, I also added 2 units, length and mass.