search

Meumeu / WiVRn

An OpenXR streaming application to a standalone headset
GNU General Public License v3.0
134 stars 22 forks source link

Enable PIE for Binaries #48

Closed damaestro closed 3 months ago

damaestro commented 3 months ago

We should enable CMAKE_POSITION_INDEPENDENT_CODE and set it to default ON.

Based on the fedora-review tool, there are four binaries that need addressing:

W: position-independent-executable-suggested /usr/bin/wivrn-server

Upstream Monado addressed this in https://gitlab.freedesktop.org/monado/monado/-/issues/337

xytovl commented 3 months ago

Shouldn't this be controlled by the packager? i.e. using -DCMAKE_POSITION_INDEPENDENT_CODE=ON when invoking cmake.

damaestro commented 3 months ago

Setting the default is better than every downstream packaging needing to set it.