Mevrael / bunny

BunnyJS - Lightweight native (vanilla) JavaScript (JS) and ECMAScript 6 (ES6) browser library, package of small stand-alone components without dependencies: FormData, upload, image preview, HTML5 validation, Autocomplete, Dropdown, Calendar, Datepicker, Ajax, Datatable, Pagination, URL, Template engine, Element positioning, smooth scrolling, routing, inversion of control and more. Simple syntax and architecture. Next generation jQuery and front-end framework. Documentation and examples available.
https://bunnyjs.com
MIT License
487 stars 39 forks source link

Pagination buttons change location URL #11

Closed joebordes closed 7 years ago

joebordes commented 7 years ago

I am testing the beta release. I have a datatable with pagination. On the previous release the page links would launch an ajax call and update the table , now those buttons, show the spinner, scroll to the top and update the URL in the browser location address. The first two new behaviors are fantastic but the URL update is a problem as it breaks the browser history and also gives a raw JSON output if you click on the "reload" browser button.

Can we revert that behavior back so the address URL is not changed? Or is there a way of deactivating that on a per-project setting?

Mevrael commented 7 years ago

Thanks for feedback @joebordes

Yes, I also noticed same problem. Will remove that first "jump" and URL rewriting on first page and do that only when page changes.

Unfortunately, it is not configurable, so it also will be updated a bit later.

For now I would recommend to stick with 0.11.x if it is not a critical issue. Will update DataTable in few days.

Mevrael commented 7 years ago

Hi @joebordes

Sorry for a delayed update. Your issue solved in latest release 0.12.3:

DataTable updated:



If you will have any questions or some of your issues were not solved, please let me know. If everything is ok for you, please close this issue.
joebordes commented 7 years ago

The URL problem is fixed. Thanks!

I haven't tried the search.

I can't see the spinner, neither in my datatable nor in the online demo. I will have a look later and open another ticket if I can't get it working.