search

Mew-Traveler / mew-api

1 stars 0 forks source link

Use unique public strings when filtering secrets in VCR #4

Open soumyaray opened 8 years ago

soumyaray commented 8 years ago

Look at the filtering you are doing here.

I'll be surprised if this isn't causing an error.

You are using the same public string <CLIENT_ID> to filter out both the airbnb and google ids. This will only work when filtering the secrets to write safely to the cassette. But it will cause a problems when your code tries to talk to the APIs again, because VCR will want to to convert <CLIENT_ID> back into the secret credential -- and it won't know which credential to use. Use different public strings for each credential, so that VCR can convert the public strings back into the right secret credential.

Make sense?

Tailcloud commented 8 years ago

@soumyaray Yes, exactly! I will check it now. However, I am not really understand the usage of the cassette utility :'(

soumyaray commented 8 years ago

VCR will record your interactions with the API and store it in a cassette file. After that, if you make the same requests to the API, VCR will play back the earlier response. Does that make sense?

On October 22, 2016 at 02:05:02, Yvonne (notifications@github.com) wrote:

@soumyaray https://github.com/soumyaray Yes, exactly! I will check it now. However, I am not really understand the usage of the cassette utility :'(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Mew-Traveler/mew-api/issues/4#issuecomment-255434997, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1mMLerxL_Dj_EgRQOVoSF0Fh268WXIks5q2P7OgaJpZM4KdSRr .