search

MewPurPur / GodSVG

An application in early development for creating simple vector graphics. Built in Godot.
https://godsvg.com
MIT License
1.06k stars 48 forks source link

Add Custom Themes #764

Open Qainguin opened 1 month ago

Qainguin commented 1 month ago

There should be a way to add custom themes to GodSVG. My idea was that there should be a singleton with all of the theme colors included and to put them in the already existing color changer on the settings popup.

MewPurPur commented 1 month ago

From the onset, I somewhat agree with the idea of splitting off a singleton for the things needed to configure a theme. But I'd like to see what a theming system would look like in practice or describe it in detail, before deciding on such an infrastructure. For example, will colors be configurable or will there just be a dictionary for interfacing with pre-made themes? Would a theming database could include things like fonts, enums for spacing, roundiness, other little numbers? (almost for sure it won't be all colors.)

tl;dr: Full agreement on custom themes. The internal specifics should come after the implementation or an agreed on specification.

Qainguin commented 1 month ago

The theming database would most likely just be for colors but could be added to later and if possible people should be able to share a single file for getting a custom theme.

MewPurPur commented 1 month ago

should be able to share a single file for getting a custom theme

Like the "Copy as XML" function for palettes? I think that'd work fine for this too.

Qainguin commented 1 month ago

Yeah, pretty much.