search

MewsSystems / mews-flutter

Flutter and Dart open-source packages maintained by Mews.
59 stars 22 forks source link

feat!: Upgrade to DCM 1.17.0 #608

Closed witwash closed 3 months ago

witwash commented 3 months ago

Summary

Upgrade to DCM 1.17.0

Enabled rules:
Rules left disabled:

Testing steps

None, linter update.

Follow-up issues

None.

Check during review

ookami-kb commented 3 months ago

@witwash links to the rules in PR description are broken.

witwash commented 3 months ago

@ookami-kb, fixed

alboiuvlad29 commented 3 months ago

avoid-collection-equality-checks we mostly use immutable lists everywhere which does deep equality comparison by default. Does this check consider that? If not we should probably disable it as it will be a pain to deal with this check afterwards.

alboiuvlad29 commented 3 months ago

I also don't see any benefit to avoid-multi-assignment as well. There are some places we do this on purpose.

ookami-kb commented 3 months ago

@alboiuvlad29 I cannot find any usage of multi-assignment.

witwash commented 3 months ago

I can see how neglecting avoid-multi-assignment can lead to less readable code 🤔. Who are you saving that one/two lines for, @alboiuvlad29? 😄

alboiuvlad29 commented 3 months ago

Never-mind, it was a different usage I had in mind and this isn't it regarding avoid-multi-assignment. Sorry about that. 😅

witwash commented 3 months ago

@chaeMil 👀

witwash commented 3 months ago

@alboiuvlad29, 🙏