Closed witwash closed 3 months ago
@witwash links to the rules in PR description are broken.
@ookami-kb, fixed
avoid-collection-equality-checks
we mostly use immutable lists everywhere which does deep equality comparison by default. Does this check consider that? If not we should probably disable it as it will be a pain to deal with this check afterwards.
I also don't see any benefit to avoid-multi-assignment
as well. There are some places we do this on purpose.
@alboiuvlad29 I cannot find any usage of multi-assignment.
I can see how neglecting avoid-multi-assignment
can lead to less readable code 🤔. Who are you saving that one/two lines for, @alboiuvlad29? 😄
Never-mind, it was a different usage I had in mind and this isn't it regarding avoid-multi-assignment
. Sorry about that. 😅
@chaeMil 👀
@alboiuvlad29, 🙏
Summary
Upgrade to DCM 1.17.0
Enabled rules:
Rules left disabled:
Testing steps
None, linter update.
Follow-up issues
None.
Check during review