feat!: [DX-1695] Limit button badge to numbers only - Githubissues

MewsSystems / mews-flutter

Flutter and Dart open-source packages maintained by Mews.

59 stars 22 forks source link

feat!: [DX-1695] Limit button badge to numbers only #615

Closed witwash closed 3 months ago

witwash commented 3 months ago

Summary

[BREAKING CHANGE] badge now accepts positive numbers only. The badgeLabel is renamed to counter to match the MDS component naming.
updated story

Preview

https://github.com/MewsSystems/mews-flutter/assets/9210422/e100032b-0b12-4644-b271-b4c94661444a

Testing steps

Open Button story
Test button counter with different variables and themes. Test exposed knobs to determine whether the look is consistent.

Follow-up issues

None

Check during review

Verify against Jira issue.
Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
Unused code removed.
Build passing.
Is it a bug fix? Check that it is covered by a proper test (unit or integration).

witwash commented 3 months ago

@chaeMil, ready