issues
search
MewsSystems
/
mews-flutter
Flutter and Dart open-source packages maintained by Mews.
59
stars
22
forks
source link
refactor!: [DX-1925] Align the naming of the feedback components
#642
Closed
witwash
closed
1 month ago
witwash
commented
1 month ago
Summary
added
isDismissible
to the
OptimusAlert
[BREAKING CHANGE]
renamed
onDismissed
to
onDissmiss
to align with the rest of the package
Testing steps
not needed, small refactor
Follow-up issues
none
Check during review
Verify against Jira issue.
Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
Unused code removed.
Build passing.
Is it a bug fix? Check that it is covered by a proper test (unit or integration).
Summary
isDismissible
to theOptimusAlert
onDismissed
toonDissmiss
to align with the rest of the packageTesting steps
Follow-up issues
none
Check during review